From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4 18/32] net/qede: add missing 100G link
	speed capability
Date: Wed, 26 Oct 2016 23:43:18 +0200
Message-ID: <1772382.AymLqBrjhc@xps13>
References: <1476850306-2141-1-git-send-email-rasesh.mody@qlogic.com>
 <4491648.SeJM0cAZEU@xps13> <D4366DC1.A5BF7%Harish.Patil@cavium.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Dept-Eng DPDK Dev <Dept-EngDPDKDev@qlogic.com>,
 ferruh.yigit@intel.com
To: Harish Patil <harish.patil@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 20A602B98
 for <dev@dpdk.org>; Wed, 26 Oct 2016 23:43:20 +0200 (CEST)
Received: by mail-wm0-f50.google.com with SMTP id e69so59821684wmg.0
 for <dev@dpdk.org>; Wed, 26 Oct 2016 14:43:20 -0700 (PDT)
In-Reply-To: <D4366DC1.A5BF7%Harish.Patil@cavium.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-10-26 21:28, Harish Patil:
>=20
> >2016-10-18 21:11, Rasesh Mody:
> >> From: Harish Patil <harish.patil@qlogic.com>
> >>=20
> >> This patch fixes the missing 100G link speed advertisement
> >> when the 100G support was initially added.
> >>=20
> >> Fixes: 2af14ca79c0a ("net/qede: support 100G")
> >>=20
> >> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> >[...]
> >>  [Features]
> >> +Speed capabilities   =3D Y
> >
> >This feature should be checked only when it is fully implemented,
> >i.e. when you return the real capabilities of the device.
> >
> >> --- a/drivers/net/qede/qede_ethdev.c
> >> +++ b/drivers/net/qede/qede_ethdev.c
> >> @@ -599,7 +599,8 @@ qede_dev_info_get(struct rte_eth_dev *eth_dev,=

> >>  =09=09=09=09     DEV_TX_OFFLOAD_UDP_CKSUM |
> >>  =09=09=09=09     DEV_TX_OFFLOAD_TCP_CKSUM);
> >> =20
> >> -=09dev_info->speed_capa =3D ETH_LINK_SPEED_25G | ETH_LINK_SPEED_4=
0G;
> >> +=09dev_info->speed_capa =3D ETH_LINK_SPEED_25G | ETH_LINK_SPEED_4=
0G |
> >> +=09=09=09       ETH_LINK_SPEED_100G;
> >>  }
> >
> >It is only faking the capabilities at driver-level.
> >You should check if the underlying device is able to achieve 100G
> >before advertising this flag to the application.
> >
> >I suggest to update this patch to remove the doc update.
> >The contract is to fill it only when the code is fixed.
> >By the way, we must call every other drivers to properly implement
> >this feature.
> >
>=20
> Hi Thomas,
> Its not really a faking. The same driver supports all three link spee=
ds.
> The required support for 100G was already present in the 16.07 inbox
> driver.
> We just had missed out advertising 100G link speed via
> dev_info->speed_capa.
> Hence it is - Fixes: 2af14ca79c0a ("net/qede: support 100G=E2=80=9D).=

> Hope it is okay.

Yes the code is okay. But it is not complete.
Please tell me you understand that you must fill speed_capa depending
of the device capabilities.
Then you will be able to fill "Speed capabilities" box in the doc.