From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 2/2] eal: fix dynamic logs failing to print Date: Tue, 21 Nov 2017 11:55:00 +0100 Message-ID: <1772478.GecVQuhyhE@xps> References: <20171116103144.4197-1-pbhagavatula@caviumnetworks.com> <20171117084722.by7sdxdoimkwdqpg@Pavan-LT> <9e17df24-9b52-620f-b299-fdc42a1083c4@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Pavan Nikhilesh Bhagavatula , olivier.matz@6wind.com, dev@dpdk.org To: Ferruh Yigit Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 282AB236 for ; Tue, 21 Nov 2017 11:55:02 +0100 (CET) In-Reply-To: <9e17df24-9b52-620f-b299-fdc42a1083c4@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/11/2017 19:40, Ferruh Yigit: > And, since you are touching these files :), > for better regex support, it may be good to have log types hierarchical, like > "lib.mbuf", "lib.mempool", "lib.eal.malloc", as done in member library but with > "lib" prefix instead of "librte", if this makes sense and you have time would > you mind sending a patch for this as well? I am not sure about using eal in the library names. I think lib.malloc is enough and it would allow to move malloc (and other libraries) outside of EAL if needed. We already moved PCI and VDEV outside of EAL. More could be moved.