From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Ananyev,
Konstantin"
<konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] EAL: move rte_common_vect.h into arch/x86
Date: Wed, 18 Mar 2015 17:02:44 +0100 [thread overview]
Message-ID: <1772941.ZquV42oMuH@xps13> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258213F71C4-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-18 15:24, Ananyev, Konstantin:
>
> Hi Thomas,
>
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > Sent: Wednesday, March 18, 2015 1:14 PM
> > To: Ananyev, Konstantin
> > Cc: dev-VfR2kkLFssw@public.gmane.org
> > Subject: Re: [dpdk-dev] [PATCH] EAL: move rte_common_vect.h into arch/x86
> >
> > Hi Konstantin,
> >
> > 2015-03-18 10:58, Konstantin Ananyev:
> > > lib/librte_eal/common/Makefile | 1 -
> > > .../common/include/arch/x86/rte_common_vect.h | 128 +++++++++++++++++++++
> > > lib/librte_eal/common/include/rte_common_vect.h | 128 ---------------------
> >
> > I think rte_vect.h is a better name as common is not anymore relevant.
>
> I don't mind, but it means more changes - all files which include it, would need to be changed.
I think file naming deserves it.
> > Should we add an empty file in ppc_64 directory?
>
> I thought about that too, but it seems not necessary.
> It is included by:
> lib/librte_lpm/rte_lpm.h
> lib/librte_eal/common/include/arch/x86/rte_memcpy.h
> lib/librte_acl/rte_acl_osdep.h
>
> As I understand, neither LPM, neither ACL are supported on PPC right now.
> Again, if we'll provide an empty one for PPC, it wouldn't help to compile LPM/ACL on PPC anyway,
> as both use SSE instrincts inside their code.
Yes, it was an open question.
It's probably better to create the PPC file when really needed.
prev parent reply other threads:[~2015-03-18 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 10:58 [PATCH] EAL: move rte_common_vect.h into arch/x86 Konstantin Ananyev
[not found] ` <1426676283-7779-1-git-send-email-konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-03-18 13:13 ` Thomas Monjalon
2015-03-18 15:24 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213F71C4-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-18 16:02 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1772941.ZquV42oMuH@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).