From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] EAL: move rte_common_vect.h into arch/x86
Date: Wed, 18 Mar 2015 17:02:44 +0100
Message-ID: <1772941.ZquV42oMuH@xps13>
References: <1426676283-7779-1-git-send-email-konstantin.ananyev@intel.com>
 <12406601.aPV9NrFM6W@xps13>
 <2601191342CEEE43887BDE71AB977258213F71C4@irsmsx105.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Ananyev, Konstantin" <konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <2601191342CEEE43887BDE71AB977258213F71C4-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2015-03-18 15:24, Ananyev, Konstantin:
> 
> Hi Thomas,
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > Sent: Wednesday, March 18, 2015 1:14 PM
> > To: Ananyev, Konstantin
> > Cc: dev-VfR2kkLFssw@public.gmane.org
> > Subject: Re: [dpdk-dev] [PATCH] EAL: move rte_common_vect.h into arch/x86
> > 
> > Hi Konstantin,
> > 
> > 2015-03-18 10:58, Konstantin Ananyev:
> > >  lib/librte_eal/common/Makefile                     |   1 -
> > >  .../common/include/arch/x86/rte_common_vect.h      | 128 +++++++++++++++++++++
> > >  lib/librte_eal/common/include/rte_common_vect.h    | 128 ---------------------
> > 
> > I think rte_vect.h is a better name as common is not anymore relevant.
> 
> I don't mind, but it means more changes - all files which include it, would need to be changed.

I think file naming deserves it.

> > Should we add an empty file in ppc_64 directory?
> 
> I thought about that too, but it seems not necessary.
> It is included by:
> lib/librte_lpm/rte_lpm.h
> lib/librte_eal/common/include/arch/x86/rte_memcpy.h
> lib/librte_acl/rte_acl_osdep.h 
> 
> As I understand, neither LPM, neither ACL are supported on PPC right now.
> Again, if we'll provide an empty one for PPC, it wouldn't help to compile LPM/ACL on PPC anyway,
> as both use SSE instrincts inside their code.

Yes, it was an open question.
It's probably better to create the PPC file when really needed.