From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] telemetry: fix shared build for make Date: Mon, 12 Nov 2018 01:23:31 +0100 Message-ID: <1773184.RcDog45q3e@xps> References: <20181107181018.80224-1-kevin.laatz@intel.com> <438ce75d-7bf6-1845-2303-d3151e0a71bf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Ferruh Yigit , harry.van.haaren@intel.com, gaetan.rivet@6wind.com, mattias.ronnblom@ericsson.com, bruce.richardson@intel.com, radu.nicolau@intel.com, ciara.power@intel.com, brian.archbold@intel.com To: Kevin Laatz Return-path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 60CA491 for ; Mon, 12 Nov 2018 01:23:36 +0100 (CET) In-Reply-To: <438ce75d-7bf6-1845-2303-d3151e0a71bf@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/11/2018 23:19, Ferruh Yigit: > On 11/7/2018 6:10 PM, Kevin Laatz wrote: > > Currently, telemetry is not working for shared builds in make. > > > > The --as-needed flag is preventing telemetry from being linked as there are > > no direct API calls from the app to telemetry. This is causing the > > --telemetry option to not be recognized by EAL. > > Telemetry registers it's EAL option using the RTE_INIT constructor. Since > > EAL's option parsing is done before the plugins init, the --telemetry > > option isn't registered at the time of parsing, and as a result, the > > --telemetry option is not being recognized. > > > > This patch fixes this issue by explicitly linking telemetry to the > > application by setting the "--no-as-needed" flag for the library in > > mk/rte.app.mk. > > > > Fixes: 8877ac688b52 ("telemetry: introduce infrastructure") > > > > Reported-by: Yanjie Xu > > Signed-off-by: Kevin Laatz > > Reviewed-by: Ferruh Yigit Applied, thanks