From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] mk: fix acl library static linking
Date: Thu, 30 Jun 2016 14:44:30 +0200
Message-ID: <1776198.xo6Bm4C5fO@xps13>
References: <1467285021-103920-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <5547616.scaE5dMnT7@xps13> <eee7ba0e-8af5-8486-6490-cfef51eb8cf7@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id CCD9A2142
 for <dev@dpdk.org>; Thu, 30 Jun 2016 14:44:35 +0200 (CEST)
Received: by mail-wm0-f54.google.com with SMTP id a66so116926302wme.0
 for <dev@dpdk.org>; Thu, 30 Jun 2016 05:44:35 -0700 (PDT)
In-Reply-To: <eee7ba0e-8af5-8486-6490-cfef51eb8cf7@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-30 13:04, Sergio Gonzalez Monroy:
> On 30/06/2016 12:38, Thomas Monjalon wrote:
> > Does it need to be commented in rte.app.mk?
> > The other libs are in whole-archive to support dlopen of drivers.
> > But the problem here is not because of a driver use.
> 
> There seem to be a bunch of libraries under --whole-archive scope that 
> are not
> PMDs, ie. cfgfile, cmdline...
> 
> What is the criteria?

The criteria is a bit vague. We must try to include only libs which can
be used by a driver.
cmdline should probably not be there.
Does it make sense to use cfgfile in a driver? maybe yes.