From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 08/14] ring: allow enqueue fns to return
	free space value
Date: Tue, 28 Mar 2017 09:12:39 +0200
Message-ID: <1777203.ud4AFtxiB3@xps13>
References: <20170307113217.11077-1-bruce.richardson@intel.com>
 <20170324171008.29355-1-bruce.richardson@intel.com>
 <20170324171008.29355-9-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: olivier.matz@6wind.com, dev@dpdk.org, jerin.jacob@caviumnetworks.com
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com
 [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id ED761D237
 for <dev@dpdk.org>; Tue, 28 Mar 2017 09:12:41 +0200 (CEST)
Received: by mail-wr0-f170.google.com with SMTP id l43so89179061wre.1
 for <dev@dpdk.org>; Tue, 28 Mar 2017 00:12:41 -0700 (PDT)
In-Reply-To: <20170324171008.29355-9-bruce.richardson@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-03-24 17:10, Bruce Richardson:
> Add an extra parameter to the ring enqueue burst/bulk functions so that
> those functions can optionally return the amount of free space in the
> ring. This information can be used by applications in a number of ways,
> for instance, with single-producer queues, it provides a max
> enqueue size which is guaranteed to work. It can also be used to
> implement watermark functionality in apps, replacing the older
> functionality with a more flexible version, which enables apps to
> implement multiple watermark thresholds, rather than just one.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>


There is a an error with this patch and crypto drivers:


drivers/crypto/kasumi/rte_kasumi_pmd.c:362:32: fatal error:
too few arguments to function call, expected 4, have 3
                                (void **)ops, processed_ops);
                                                           ^
rte_ring.h:1018:1: note: 'rte_ring_enqueue_burst' declared here


drivers/crypto/snow3g/rte_snow3g_pmd.c:366:31: fatal error:
too few arguments to function call, expected 4, have 3
                        (void **)ops, processed_ops);
                                                   ^
rte_ring.h:1018:1: note: 'rte_ring_enqueue_burst' declared here