From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [Process] Git Fixline Suggestion Date: Wed, 12 Jul 2017 12:49:58 +0200 Message-ID: <1777813.DZOk1ehyER@xps> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Van Haaren, Harry" Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 803FC3257 for ; Wed, 12 Jul 2017 12:50:00 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/07/2017 10:40, Van Haaren, Harry: > Hi All, > > I propose to add CC: to the output of the git fixline command[1]. > > The logic here is that if it is a fix to the previous code, the original author of that code should be informed. Currently the author must read the mailing-list carefully in order to ensure that no patches are missed, that fix code that they are the author of. > > The new workflow is the same as before: copy the output of "git fixline" into the commit message. The output would now be two lines as follows: > > Fixes: 17b8320a3e11 ("vhost: remove index parameter") > cc: author@domain.com > > > The following git fixline achieves this: > > git log -1 --abbrev=12 --format="Fixes: %h (\"%s\")%nCC:%ae" > > > Opinions? -Harry Good idea. Two comments: - minor nit: CC should be Cc to be consistent with what is suggested by check-git-log.sh for stable@dpdk.org. - Do we want to keep this Cc in the git history or is it just to notify people on the mailing list? I think it is good to keep in history the tags Acked-by: or Reviewed-by:. But if the author does not review the fix, I do not see the benefit of saving his name in the history.