From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4] examples/vhost_scsi: fix buffer not terminated Date: Wed, 25 Oct 2017 12:18:58 +0200 Message-ID: <1778128.TuySi4b6Nz@xps> References: <1507808061-37679-1-git-send-email-jacekx.piasecki@intel.com> <1508926038-12821-1-git-send-email-jacekx.piasecki@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, maxime.coquelin@redhat.com, yliu@fridaylinux.org, changpeng.liu@intel.com, stable@dpdk.org To: Jacek Piasecki Return-path: In-Reply-To: <1508926038-12821-1-git-send-email-jacekx.piasecki@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/10/2017 12:07, Jacek Piasecki: > Use snprintf instead strncpy to get safe null string termination. > There was possible to get not terminated string after strncpy operation. > > Coverity issue: 158631 > Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app") > Cc: changpeng.liu@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Jacek Piasecki > Acked-by: Maxime Coquelin > --- > v4: RTE_DIM instead ARRAY_SIZE > v3: checkpatch fix > v2: snprintf instead strncpy Applied, thanks