From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] fbarray: support no-shconf Date: Tue, 22 May 2018 22:38:30 +0200 Message-ID: <1778895.HHJToTI6Sl@xps> References: <80aff8bc0255cdab2331dcb0b21219d50f154937.1527006762.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Anatoly Burakov Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 905631DA4 for ; Tue, 22 May 2018 22:38:32 +0200 (CEST) In-Reply-To: <80aff8bc0255cdab2331dcb0b21219d50f154937.1527006762.git.anatoly.burakov@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/05/2018 18:35, Anatoly Burakov: > When using --no-shconf option, the expectation is that no multiprocess > will be supported as no shared files are created. However, fbarray > still creates some shared files that prevent multiple processes with > the same prefix from starting. > > Fix this by avoiding creating shared files whenever noshconf option is > specified. Since virtual areas we get from eal_get_virtual_area() are > read-only, remap them as writable. > > Signed-off-by: Anatoly Burakov > --- > > Notes: > Without this patch, EAL flags autotest will fail when attempting > to run a test with the same prefix as primary, and --no-shconf > specified. > > Technically, we never spelled out any guarantees about --no-shconf > mode, and we've been sloppy about it, so even though we don't create > the shared config, we still create lots of other miscelaneous files. > This patch only fixes issue with fbarray, as this affects intialization > of different primaries with the same prefix (fbarrays are shared too), > but does not address the other instances where we create "shared" files > such as hugepage info. Just for confirmation: this patch won't be integrated in 18.05.