From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: crypto pmds can only be built if librte_cryptodev is enabled Date: Fri, 11 Mar 2016 10:40:57 +0100 Message-ID: <17792541.ug2j2xNN4L@xps13> References: <9127451bf67ce08532a327cb66aefbcf7ed5b39f.1457687628.git.pmatilai@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Panu Matilainen Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id BAE832BF6 for ; Fri, 11 Mar 2016 10:42:40 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id l68so10467870wml.0 for ; Fri, 11 Mar 2016 01:42:40 -0800 (PST) In-Reply-To: <9127451bf67ce08532a327cb66aefbcf7ed5b39f.1457687628.git.pmatilai@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-11 11:13, Panu Matilainen: > If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled, > build of any crypto pmds will fail because of the missing dependency. > This has been present for a while now but hidden until the addition > of null_crypto since all the other crypto pmds have been disabled > by default. > > Conditionalize the entire drivers/crypto directory on > CONFIG_RTE_LIBRTE_CRYPTODEV to fix. > > Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") > > Signed-off-by: Panu Matilainen Applied with small rework, thanks. > +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) > DIRS-y += crypto > +endif DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto