From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 0/3] ethdev: fail if requested offload is
 not supported
Date: Mon, 18 Jun 2018 09:43:59 +0100
Message-ID: <177b4268-c4dc-54f6-1d9b-b7573f444f44@intel.com>
References: <1526055955-14027-1-git-send-email-arybchenko@solarflare.com>
 <1526283378-30507-1-git-send-email-arybchenko@solarflare.com>
 <DB7PR05MB44269E4EBE8A350E70F0B458C39C0@DB7PR05MB4426.eurprd05.prod.outlook.com>
 <fa6e0c36-07b7-1c6c-68c0-59781ee5bd88@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>, Wei Dai <wei.dai@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id A3C9A98
 for <dev@dpdk.org>; Mon, 18 Jun 2018 10:44:03 +0200 (CEST)
In-Reply-To: <fa6e0c36-07b7-1c6c-68c0-59781ee5bd88@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/14/2018 3:48 PM, Ferruh Yigit wrote:
> On 5/14/2018 8:51 AM, Shahaf Shuler wrote:
>> Monday, May 14, 2018 10:36 AM, Andrew Rybchenko:
>>> Subject: [PATCH v2 0/3] ethdev: fail if requested offload is not supported
>>>
>>> The series has fixes for problems discussed in [1].
>>>
>>> Basically it does not allow unsupported offloads to pass.
>>>
>>> If fixes regressions for PMDs which carefully check offloads before, but these
>>> checks are removed now in favor of checks in ethdev.
>>>
>>> It may break applications which request some offload which is not supported
>>> by underlying PMD, but does not actually used.
>>>
>>> Depending on discussion results it should be either dropped or applied.
>>>
>>> [1]
>>> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd
>>> k.org%2Fml%2Farchives%2Fdev%2F2018-
>>> May%2F101261.html&data=02%7C01%7Cshahafs%40mellanox.com%7C9a572
>>> e9d86b04c99854c08d5b96d75b5%7Ca652971c7d2e4d9ba6a4d149256f461b%7
>>> C0%7C0%7C636618802134607945&sdata=fQKCr%2FrFvakWVIFomy8iSD%2Bc
>>> VtSie8mvgx63Qqgq690%3D&reserved=0
>>>
>>> v1 -> v2:
>>>  - use IGNORE flag to separate old and new offload API cases on
>>>    Tx queue setup and avoid expected errors if old API is used
>>>    as suggested by Shahaf
>>>  - remove convertion of rxmode bits on Rx queue setup since exactly
>>>    these bits are removed
>>>
>>> Andrew Rybchenko (3):
>>>   ethdev: fail configure if requested offload is not supported
>>>   ethdev: fail if Tx queue offload is not supported
>>>   ethdev: fail if Rx queue offload is not supported
>>>
>>>  lib/librte_ethdev/rte_ethdev.c | 62 +++++++++++++++++++---------------
>>>  1 file changed, 35 insertions(+), 27 deletions(-)
>>
>> For the series -
>> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> 
> Updated status of the set as deferred in patchwork, lets continue to work on
> this after release.

This set should not be valid anymore after adding error returns back and
removing old offloading API in this release. Updating patchwork according.