From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] devtools: check wrong svg include in
	guides
Date: Thu, 01 Nov 2018 10:27:01 +0100
Message-ID: <1782447.EoLl64vPQU@xps>
References: <20181031110548.31184-1-thomas@monjalon.net>
 <20181031162842.19431-1-thomas@monjalon.net>
 <CAKy9EB3PL9vFV7H6xEwiskBcyQEfEXPfnV6xMv=XVoEUUwsFrQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com
To: Arnon Warshavsky <arnon@qwilt.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B9376B62
 for <dev@dpdk.org>; Thu,  1 Nov 2018 10:27:04 +0100 (CET)
In-Reply-To: <CAKy9EB3PL9vFV7H6xEwiskBcyQEfEXPfnV6xMv=XVoEUUwsFrQ@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

01/11/2018 07:45, Arnon Warshavsky:
> Hi
> 
> >PS: the warning contains the regex. May it be improved?
> 
> How about passing an explicit warning message to the awk instead of the
> regex?

Yes it is a good idea.
I think it can be a separate patch. Would you like to send it please?

[..]
> +       if [ $? -ne 0 ] ; then
> +                ret=1
> +       fi
> +
> +       return $ret
>  }
> 
> I also noticed that there is a need to keep the return value from each
> check in case the first fails and the latter succeeds

No need of return code.
The error is detected if there is something printed to stdout.