From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] vdev: fix rte_mp_request_sync() memleak on
	scan
Date: Thu, 25 Oct 2018 16:06:32 +0200
Message-ID: <1782616.ReFsLbzSkl@xps>
References: <20181025104735.137381-1-dariusz.stojaczyk@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, anatoly.burakov@intel.com, jianfeng.tan@intel.com,
 qi.z.zhang@intel.com, stable@dpdk.org, Paul Luse <paul.e.luse@intel.com>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20181025104735.137381-1-dariusz.stojaczyk@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

This patch was already sent, reviewed and applied.
Why do you re-send it?

25/10/2018 12:47, Darek Stojaczyk:
> rte_mp_request_sync() says that the caller is responsible
> for freeing one of its parameters afterwards. vdev didn't
> do that, causing a memory leak.
> 
> Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel")
> Cc: jianfeng.tan@intel.com
> Cc: qi.z.zhang@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Paul Luse <paul.e.luse@intel.com>
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> ---
>  drivers/bus/vdev/vdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
> index 688e31c21..685cc4e78 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -425,6 +425,7 @@ vdev_scan(void)
>  			mp_rep = &mp_reply.msgs[0];
>  			resp = (struct vdev_param *)mp_rep->param;
>  			VDEV_LOG(INFO, "Received %d vdevs", resp->num);
> +			free(mp_reply.msgs);
>  		} else
>  			VDEV_LOG(ERR, "Failed to request vdev from primary");
>  
>