From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] app/testpmd: fix icmp echo tx queues
Date: Tue, 10 Nov 2015 16:27:52 +0100
Message-ID: <1782730.BzREnyClfV@xps13>
References: <1446108423-14231-1-git-send-email-david.marchand@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: pablo.de.lara.guarch@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id CEFF22E83
 for <dev@dpdk.org>; Tue, 10 Nov 2015 16:29:04 +0100 (CET)
Received: by wmec201 with SMTP id c201so139295600wme.0
 for <dev@dpdk.org>; Tue, 10 Nov 2015 07:29:04 -0800 (PST)
In-Reply-To: <1446108423-14231-1-git-send-email-david.marchand@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-10-29 09:47, David Marchand:
> icmp echo forward engine relies on the core rank rather than the number of
> queues available.
> This fix is still wrong, because if we set a nb-rxq > nb-txq, then we will use
> an invalid txq, but with this, we are aligned on other fwd engines.
> 
> Signed-off-by: David Marchand <david.marchand@6wind.com>
[...]
> -			fs->tx_queue = lc_id;
> +			fs->tx_queue = rxq;

Pablo, any opinion?