From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] pmd_ring: return new port id on ethdev creation Date: Mon, 22 Jun 2015 17:33:15 +0200 Message-ID: <1784806.DNuCGtV9V3@xps13> References: <1434634121-24036-1-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 5C206C6FA for ; Mon, 22 Jun 2015 17:34:17 +0200 (CEST) Received: by wibdq8 with SMTP id dq8so79163876wib.1 for ; Mon, 22 Jun 2015 08:34:17 -0700 (PDT) In-Reply-To: <1434634121-24036-1-git-send-email-bruce.richardson@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > The rte_eth_from_rings API allowed the creation of an ethdev port at > runtime using rte_rings as the underlying storage. However, the return > value from this function was either 0 or -1, and these values were never > actually documented in the API documentation. Unfortunately, the programmers > guide doc examples for this API implied that the return value from this > function was the port id of the newly created ethdev. > > Since this latter behaviour is more useful - and already implied by the > documentation, this patch changes the return 0 to "return > data->port_id". It also adds in doxygen comments for the function so it > can be correctly documented in the API reference. > > Signed-off-by: Bruce Richardson Applied, thanks