From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] examples/vhost: Fix vlan offload issue Date: Tue, 16 Dec 2014 17:36:57 +0100 Message-ID: <1785187.jrxsoh9Kkn@xps13> References: <1418357726-25141-1-git-send-email-changchun.ouyang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Ouyang Changchun Return-path: In-Reply-To: <1418357726-25141-1-git-send-email-changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-12-12 12:15, Ouyang Changchun: > The following commit break vm2vm hard mode test cases: > commit db4014f2b65cb31bf209cadd5bcec778ca137fe2 > Author: Huawei Xie > Date: Thu Nov 13 06:34:07 2014 +0800 > examples/vhost: use factorized default Rx/Tx configuration > > Investigation show that it needs enabling vlan offload since it is turn off by default, > and Tx need it, especially when vm2vm is in hard mode. I missed something here. Where VLAN offload is disabled by default? Could you point the code, please? > --- a/examples/vhost/main.c > +++ b/examples/vhost/main.c > @@ -390,6 +390,9 @@ port_init(uint8_t port) > txconf = &dev_info.default_txconf; > rxconf->rx_drop_en = 1; > > + /* Enable vlan offload */ > + txconf->txq_flags &= ~ETH_TXQ_FLAGS_NOVLANOFFL; > + > /* > * Zero copy defers queue RX/TX start to the time when guest > * finishes its startup and packet buffers from that guest are >