From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 3/3] examples/l3fwd: format the IP addresses for printing Date: Fri, 22 Jun 2018 15:44:51 +0200 Message-ID: <1789949.7rL1TaZSp4@xps> References: <20180618213557.15209-1-stephen@networkplumber.org> <20180618213557.15209-4-stephen@networkplumber.org> <8CEF83825BEC744B83065625E567D7C260CB71A8@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Stephen Hemminger , "dev@dpdk.org" To: "Iremonger, Bernard" Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 086671B611 for ; Fri, 22 Jun 2018 15:44:54 +0200 (CEST) In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CB71A8@IRSMSX108.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/06/2018 12:23, Iremonger, Bernard: > Hi Stephen, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Monday, June 18, 2018 10:36 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH v3 3/3] examples/l3fwd: format the IP addresses for > > printing > > > > It is better user experience to print standard format for addresses rather than > > raw hex. > > > > Signed-off-by: Stephen Hemminger > > --- > > examples/l3fwd/l3fwd_lpm.c | 15 ++++++++++----- > > > > dpdk/devtools/check-git-log.sh -1 > Wrong beginning of commit message: > It is better user experience to print standard format for addresses > > It is complaining about "It" in the commit message, not sure why. > > Hi Thomas, > > Could this be a bug in the check-git-log script. No it is not a bug, just a pedantic warning :) Look at this commit for the explanation: http://git.dpdk.org/dpdk/commit/?id=9c24780f0d5efd