From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 2/2] mem: unmap unneeded space Date: Mon, 14 May 2018 01:33:50 +0200 Message-ID: <1790443.DjOxLm43Na@xps> References: <4409303.1sNuYAC1ue@xps> <1968691.VWAu9saNLK@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Bruce Richardson To: Anatoly Burakov Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 09ECE1BD12 for ; Mon, 14 May 2018 01:33:52 +0200 (CEST) In-Reply-To: <1968691.VWAu9saNLK@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/05/2018 22:20, Thomas Monjalon: > 02/05/2018 23:00, Thomas Monjalon: > > 30/04/2018 14:50, Bruce Richardson: > > > On Mon, Apr 30, 2018 at 12:21:43PM +0100, Anatoly Burakov wrote: > > > > When we ask to reserve virtual areas, we usually include > > > > alignment in the mapping size, and that memory ends up > > > > being wasted. Wasting a gigabyte of VA space while trying to > > > > reserve one gigabyte is pretty expensive on 32-bit, so after > > > > we're done mapping, unmap unneeded space. > > > > > > > > Signed-off-by: Anatoly Burakov > > > > --- > > > > > > > > Notes: > > > > v2: > > > > - Split fix for size_t overflow into separate patch > > > > - Improve readability of unmapping code > > > > - Added comment explaining why unmapping is done > > > > > > > Acked-by: Bruce Richardson > > > > I am not confident pushing this change post-rc1. > > Please can we have more validation tests with this patch? > > Any news about validation tests? No news, but I've decided to push it anyway. Series applied