From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5] eal_common_cpuflags: Fix %rbx corruption, and simplify the code Date: Wed, 02 Apr 2014 13:53:24 +0200 Message-ID: <1795579.cUqpENC9aa@xps13> References: <20140320163921.GC7721@hmsreliant.think-freely.org> <5331EC38.2070901@linux.intel.com> <20140402111643.GB6974@neilslaptop.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org, "H. Peter Anvin" To: Neil Horman Return-path: In-Reply-To: <20140402111643.GB6974-0o1r3XBGOEbbgkc5XkKeNuvMHUBZFtU3YPYVAmT7z5s@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-04-02 07:16, Neil Horman: > On Tue, Mar 25, 2014 at 01:51:04PM -0700, H. Peter Anvin wrote: > > On 03/25/2014 12:52 PM, Neil Horman wrote: > > > Neil Horman reported that on x86-64 the upper half of %rbx would get > > > clobbered when the code was compiled PIC or PIE, because the > > > i386-specific code to preserve %ebx was incorrectly compiled. > > > > > > However, the code is really way more complex than it needs to be. For > > > one thing, the CPUID instruction only needs %eax (leaf) and %ecx > > > (subleaf) as parameters, and since we are testing for bits, we might > > > as well list the bits explicitly. Furthermore, we can use an array > > > rather than doing a switch statement inside a structure. > > > > > > Reported-by: Neil Horman > > > Signed-off-by: H. Peter Anvin > > > Signed-off-by: Neil Horman > > > > Looks good to me. > > > > Reviewed-by: H. Peter Anvin > > > > -hpa > > Bump, did this get lost somewhere? Its been over a week and I don't see it > in the tree No, it's not lost. But this patch is not trivial and there were 5 versions with acknowledgements in the middle. So I think it was not a bad idea to wait few days in order to be sure this version is OK :) -- Thomas