From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3B57C4649B for ; Fri, 5 Jul 2019 12:30:21 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 739952184C for ; Fri, 5 Jul 2019 12:30:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="A/QlrMUX"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="qWKyLPoq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 739952184C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D4F91BE90; Fri, 5 Jul 2019 14:30:20 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 2C1551BE8F for ; Fri, 5 Jul 2019 14:30:18 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BE20921F32; Fri, 5 Jul 2019 08:30:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 05 Jul 2019 08:30:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=DtQtCwUAIRDu2nyyKVae3QzZI+87k/be6tUw3xZDbmE=; b=A/QlrMUX7DUR jtb6JPE4TDnnuVJyT8ET8w+mDw5t+CxrUQL+7TOaFL1BFUMqwZCBFkN6o1YwmHA7 VXK99gbZzUh7VcKXg+lhRuEKekvSK+T16OQLFrkHHQKzTwe5if5AtUxHjLUTLehi lILOBR0mLFhKPWGTxKWjFNgaqZtIT8M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=DtQtCwUAIRDu2nyyKVae3QzZI+87k/be6tUw3xZDb mE=; b=qWKyLPoq7Cu5VIxDM1xH/7FlKyTfi5zMK9Mx8ZciERYgSGFIpuLTy1Vba 7sIP+a84YaSYD1XHtr0BRuUkqQUMANeEtnrr9LxkiiIM/VppHnzTWWmjnYy9+nh7 e1XYrEVPrlQ30+fJ94T62iL/hhDut+rF7m/iolza6o4ioyWyP7GQztaqpjR17zjs Hgd9C4zWb8Kg4Fqku3A0RXgmZCyuB/SqfxQ95cholxHIy340o2sk7QiO/8H92jyd wYIKbfq3nxNHeY2vUDh5o+6cdCr9Sea4eVF+EpP+pv0oUMIpqsqiiJfKqQRQu88f dXaqWsGhjGLlhGHdNjnMEncwqrthg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrfeeggdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A4F10380079; Fri, 5 Jul 2019 08:30:16 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal , Fan Zhang Cc: dev@dpdk.org, "pablo.de.lara.guarch@intel.com" Date: Fri, 05 Jul 2019 14:30:14 +0200 Message-ID: <1797255.U67UyW4ygL@xps> In-Reply-To: References: <20190320133207.58826-1-roy.fan.zhang@intel.com> <20190624133522.80732-1-roy.fan.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] cryptodev: make xform key pointer constant X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/06/2019 14:46, Akhil Goyal: > > > > > This patch changes the key pointer data types in cipher, auth, > > and aead xforms from "uint8_t *" to "const uint8_t *" for a > > more intuitive and safe sessionn creation. > > > > Signed-off-by: Fan Zhang > > Acked-by: Arek Kusztal > > Acked-by: Akhil Goyal > > --- > > v4: > > - Removed deprecation notice and updated release note. > > - Updated ABI version. > > > > v3: > > - rebased on top of latest dpdk-next-crypto > > > > v2: > > - fixed a missed memory free for ixgbe ipsec > > Applied to dpdk-next-crypto > The changes related to update for ABI version were incomplete in this patch, so they were dropped. Another patch from Anoob was also updating the ABI version, so not required in this patch. I think this patch is not complete, because there is a compilation issue with mvsam PMD when compiling arm64-thunderx-linux-gcc: drivers/crypto/mvsam/rte_mrvl_pmd.c:260:35: error: assignment discards 'const' qualifier from pointer target type