From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 1/1] ixgbe: Fix phy errors in
	stats->ierrors
Date: Thu, 23 Jul 2015 15:00:21 +0200
Message-ID: <1798990.EYfMvRFpM3@xps13>
References: <1437395309-197026-1-git-send-email-maryam.tahhan@intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC0909CFB94D@shsmsx102.ccr.corp.intel.com>
 <86228AFD5BCD8E4EBFD2B90117B5E81E10E67623@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Nemeth, Balazs" <balazs.nemeth@intel.com>
To: "Tahhan, Maryam" <maryam.tahhan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
 [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id E782FC370
 for <dev@dpdk.org>; Thu, 23 Jul 2015 15:01:34 +0200 (CEST)
Received: by wibud3 with SMTP id ud3so217921971wib.0
 for <dev@dpdk.org>; Thu, 23 Jul 2015 06:01:34 -0700 (PDT)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E10E67623@SHSMSX103.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > > Fixes: f6bf669b990004dc69231476d9fcf0b80574e568. Bug fix to remove
> > > (rxnfgpc - hw_stats->gprc) which does not account for phy errors.
> > > hw_stats->gprc is the Number of good (non-erred) Rx packets (from the
> > > network) that pass L2 filtering and has a legal length as defined by
> > > LongPacketEnable. While rxnfgpc is the Number of good (non-erred with
> > legal
> > > length) Rx packets (from the network) regardless of packet filtering and
> > receive
> > > enablement. Thus hw_stats->gprc can be > rxnfgpc and this calculation
> > should
> > > be removed from the calculation of ierrors.
> > > Validated with testpmd by sending packets to the interface without
> > forwarding
> > > enabled - packets should be dropped and the error counters incremented.
> > >
> > > v2:
> > >  - specified the commit that this bug fix fixes.
> > >
> > > Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
> > Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Tested-by: Marvin Liu <yong.liu@intel.com>

Applied, thanks