From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 3/4] net/failsafe: replace local
	sub-device with shared data
Date: Tue, 05 Mar 2019 10:59:04 +0100
Message-ID: <1800287.8gbLoiznbb@xps>
References: <1551779507-10857-1-git-send-email-rasland@mellanox.com>
 <1551779507-10857-3-git-send-email-rasland@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>
To: Raslan Darawsheh <rasland@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 052812BA7
 for <dev@dpdk.org>; Tue,  5 Mar 2019 10:59:10 +0100 (CET)
In-Reply-To: <1551779507-10857-3-git-send-email-rasland@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

05/03/2019 10:52, Raslan Darawsheh:
> +/*
> + * Allocated in shared memory.
> + */
>  struct sub_device {
>  	/* Exhaustive DPDK device description */
>  	struct sub_device *next;
>  	struct rte_devargs devargs;
> -	struct rte_bus *bus;
> -	struct rte_device *dev;
> -	struct rte_eth_dev *edev;
> +	struct rte_bus *bus; /* per process. */
> +	struct rte_device *dev; /* per process. */

Thinking again about these comments.
Given it is in a shared struct, it would be more precise to say
"only for primary process".

> +	struct rte_eth_dev_data *data; /* shared between processes */