From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 11/15] net/avp: packet receive functions
Date: Wed, 01 Mar 2017 15:14:57 +0100
Message-ID: <1802328.ieTeZWi1ce@xps13>
References: <1487985795-136044-1-git-send-email-allain.legacy@windriver.com>
 <20170228102701.GA141940@bricha3-MOBL3.ger.corp.intel.com>
 <70A7408C6E1BFB41B192A929744D85238A75943B@ALA-MBC.corp.ad.wrs.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "RICHARDSON, BRUCE" <bruce.richardson@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>, "YIGIT,
 FERRUH" <ferruh.yigit@intel.com>
To: "Legacy, Allain" <Allain.Legacy@windriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 9E807559A
 for <dev@dpdk.org>; Wed,  1 Mar 2017 15:14:59 +0100 (CET)
Received: by mail-wm0-f46.google.com with SMTP id n11so299452wma.0
 for <dev@dpdk.org>; Wed, 01 Mar 2017 06:14:59 -0800 (PST)
In-Reply-To: <70A7408C6E1BFB41B192A929744D85238A75943B@ALA-MBC.corp.ad.wrs.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-03-01 13:23, Legacy, Allain:
> > -----Original Message-----
> > From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> > In my experience, checkpatch ignores long lines that are due to error
> > messages. Perhaps you need to put the error message on a separate line,
> > if other things before the message are of significant size.
> I have gone through the entire patchset and reverted my previous changes to reduce line length on any occurrences of debug log strings.   I kept the error message on the first line and all input variables on subsequent lines (and no longer than 80).   checkpatches.sh flags most of them as warnings, but since unbroken strings seems more important I will submit my next patchset version (v3) like this. 
> 
> WARNING:LONG_LINE_STRING: line over 80 characters
> #120: FILE: drivers/net/avp/avp_ethdev.c:236:
> +			PMD_DRV_LOG(ERR, "Timeout while waiting for a response for %u\n",
> 

There is maybe something to fix in the checkpatches.sh options.
Please could you look at SPLIT_STRING and LONG_LINE_STRING?