From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v7 2/9] ethdev: add switch identifier
	parameter to port
Date: Tue, 24 Apr 2018 18:38:50 +0200
Message-ID: <1803181.YsptMJqBZT@xps>
References: <20180328135433.20203-1-declan.doherty@intel.com>
 <20180416130605.6509-1-declan.doherty@intel.com>
 <20180416130605.6509-3-declan.doherty@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, Shahaf Shuler <shahafs@mellanox.com>
To: Declan Doherty <declan.doherty@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E8F6D2B92
 for <dev@dpdk.org>; Tue, 24 Apr 2018 18:38:53 +0200 (CEST)
In-Reply-To: <20180416130605.6509-3-declan.doherty@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

16/04/2018 15:05, Declan Doherty:
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> +/**
> + * Default values for switch domain id when ethdev does not support switch
> + * domain definitions.

values -> value

> + */
> +#define RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID	(0)
> +
> +/**
> + * Ethernet device associated switch information
> + */
> +struct rte_eth_switch_info {
> +	const char *name;	/**< switch name */
> +	uint16_t domain_id;	/**< switch domain id */
> +	uint16_t port_id;	/**< switch port id */

I feel we need more details about what is the "switch port id".

[...]
> @@ -1054,6 +1069,8 @@ struct rte_eth_dev_info {
>  	struct rte_eth_dev_portconf default_rxportconf;
>  	/** Tx parameter recommendations */
>  	struct rte_eth_dev_portconf default_txportconf;
> +	/** ethdev switch information */

Can we reword it to express that it is about the hardware
built-in switch hard wired to this port?

> +	struct rte_eth_switch_info switch_info;
>  };