From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ixgbevf: fix link status for PF up/down events Date: Mon, 22 Jun 2015 12:17:46 +0200 Message-ID: <1804687.NP6EMIYIdi@xps13> References: <1434465528-12907-1-git-send-email-sergio.gonzalez.monroy@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Sergio Gonzalez Monroy Return-path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 3EF0BC7E6 for ; Mon, 22 Jun 2015 12:18:48 +0200 (CEST) Received: by wgck11 with SMTP id k11so9815108wgc.0 for ; Mon, 22 Jun 2015 03:18:48 -0700 (PDT) In-Reply-To: <1434465528-12907-1-git-send-email-sergio.gonzalez.monroy@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-06-16 15:38, Sergio Gonzalez Monroy: > Current ixgbe VF base driver only really read the status register when: > - get_link_status is true > - link reset > - mailbox timeout. > > We only set get_link_status to true when we start the PF/VF, so > following calls to ixgbe_dev_link_update will just keep the old link > status unless the link has been reset. > > Because of this behaviour, when the link status of the PF changes after > the VF has been initialized, we do not read the current status register > from the nic and instead we just keep the old link status. > > Fix the problem by setting this field to true before calling > ixgbe_check_link function from base driver. We don't need to check after > this call for get_link_status anymore, so remove it. > > Signed-off-by: Sergio Gonzalez Monroy Applied, thanks