From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 07/10] devargs: make devargs list private Date: Sun, 22 Apr 2018 23:46:03 +0200 Message-ID: <1809088.IPTTQtQtOC@xps> References: <0cba341b51ad8533a4c8accf87e1171fac8595fd.1521587199.git.gaetan.rivet@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Gaetan Rivet Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D012A2951 for ; Sun, 22 Apr 2018 23:46:05 +0200 (CEST) In-Reply-To: <0cba341b51ad8533a4c8accf87e1171fac8595fd.1521587199.git.gaetan.rivet@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/03/2018 00:20, Gaetan Rivet: > Initially, rte_devargs was meant to be populated once and sometimes > accessed, then never emptied. > > With the new hotplug functionality having better standing, new usage > appeared with repeated addition of devices and their subsequent removal. > > Exposing devargs_list pushed bus drivers and libraries to be careless > and inconsistent in their memory management. Making it private will > allow to rationalize this part of the EAL and ensure that fewer memory > leaks occur during operations. > > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/common/eal_common_devargs.c | 3 +++ > lib/librte_eal/common/include/rte_devargs.h | 6 ------ > lib/librte_eal/rte_eal_version.map | 1 - > 3 files changed, 3 insertions(+), 7 deletions(-) You must remove the related line in deprecation notice.