From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v6] net/i40e: add interface to use latest vec
	path
Date: Mon, 17 Sep 2018 16:37:20 +0200
Message-ID: <1809280.mxVWNlHP3Y@xps>
References: <1535595399-430873-1-git-send-email-xiaoyun.li@intel.com>
 <20180917095807.14421-1-xiaoyun.li@intel.com>
 <5f583daf-cd66-e675-667f-dc7dabbae97b@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Xiaoyun Li <xiaoyun.li@intel.com>, beilei.xing@intel.com,
 qi.z.zhang@intel.com, dev@dpdk.org, zhiyong.yang@intel.com,
 Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 1BB0D1B069
 for <dev@dpdk.org>; Mon, 17 Sep 2018 16:37:25 +0200 (CEST)
In-Reply-To: <5f583daf-cd66-e675-667f-dc7dabbae97b@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

17/09/2018 16:14, Ferruh Yigit:
> On 9/17/2018 10:58 AM, Xiaoyun Li wrote:
> > @@ -1078,6 +1078,9 @@ struct i40e_adapter {
> >  	uint64_t pctypes_tbl[I40E_FLOW_TYPE_MAX] __rte_cache_min_aligned;
> >  	uint64_t flow_types_mask;
> >  	uint64_t pctypes_mask;
> > +
> > +	/* For devargs */
> > +	bool use_latest_vec;
> 
> For this one checkpatch is giving following warning:
> 
> CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible
> alignment issues - see: https://lkml.org/lkml/2017/11/21/384
> 
> The comment in the link seems valid. What do you think using a basic storage
> type for the variable, like uint8_t?
> 
> 
> And overall is there any objection to follow this new convention?

I agree with avoiding bool in structs.