From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] net/af_packet: fix build failure because of unused parameter Date: Mon, 25 Sep 2017 16:24:21 +0200 Message-ID: <1809804.5fyl0q0CTl@xps> References: <1506322206-30233-1-git-send-email-arybchenko@solarflare.com> <510427f2-5761-024f-791a-7d44c58231c9@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Bruce Richardson , Andrew Rybchenko , dev@dpdk.org, Chas Williams To: Ferruh Yigit Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6A6735599 for ; Mon, 25 Sep 2017 16:24:22 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/09/2017 12:06, Ferruh Yigit: > On 9/25/2017 10:53 AM, Ferruh Yigit wrote: > > On 9/25/2017 10:40 AM, Bruce Richardson wrote: > >> On Mon, Sep 25, 2017 at 09:42:56AM +0100, Ferruh Yigit wrote: > >>> It is a little to late for this, I already sent a pull-request with this > >>> patch. So fix will need to be a separate patch. > >>> > >> Pull request hasn't actually been pulled yet, so you should be able to > >> supercede it by a later one, right? > > > > Technically yes, and easy to do, but it will be confusing. I was taking > > pull-request as code freeze in sub-tree. > > > > If there are multiple pull-request for a tree, how can one be sure which > > ones has been pulled and what to expect in main repo, and verify what > > has been merged? > > > > As above said, if Thomas thinks this is OK, I can send another pull request? > > What about Thomas doing the squash while applying to the main repo, so > that main repo won't be broken and there won't be multiple pull requests > around? Yes, no need of sending a new pull request.