From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 2/2] octeontx: move mbox to common folder
Date: Tue, 27 Mar 2018 18:15:56 +0200
Message-ID: <1810472.xOB8M7Gf6E@xps>
References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com>
 <20180326075344.2209-1-pbhagavatula@caviumnetworks.com>
 <20180326075344.2209-2-pbhagavatula@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com,
 santosh.shukla@caviumnetworks.com, anatoly.burakov@intel.com,
 lironh@marvell.com, bruce.richardson@intel.com, fiona.trahe@intel.com,
 shreyansh.jain@nxp.com, hemant.agrawal@nxp.com
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 0AA402BD3
 for <dev@dpdk.org>; Tue, 27 Mar 2018 18:15:59 +0200 (CEST)
In-Reply-To: <20180326075344.2209-2-pbhagavatula@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

26/03/2018 09:53, Pavan Nikhilesh:
> Move commonly used functions across mempool, event and net devices to a
> common folder in drivers.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>  drivers/common/Makefile                            |  4 ++
>  drivers/common/meson.build                         |  1 +
>  drivers/common/octeontx/Makefile                   | 24 ++++++++
>  drivers/common/octeontx/meson.build                |  6 ++
>  .../{mempool => common}/octeontx/octeontx_mbox.c   | 65 +++++++++++++++++-----
>  .../{mempool => common}/octeontx/octeontx_mbox.h   | 14 +++++
>  .../octeontx/rte_common_octeontx_version.map       |  9 +++
>  drivers/event/octeontx/Makefile                    |  4 +-
>  drivers/event/octeontx/meson.build                 |  5 +-
>  .../{mempool => event}/octeontx/octeontx_ssovf.c   | 20 ++++++-
>  drivers/mempool/octeontx/Makefile                  |  5 +-
>  drivers/mempool/octeontx/meson.build               |  6 +-
>  drivers/mempool/octeontx/octeontx_fpavf.c          |  4 --
>  drivers/mempool/octeontx/octeontx_pool_logs.h      |  9 ---
>  .../octeontx/rte_mempool_octeontx_version.map      |  6 --
>  drivers/net/octeontx/Makefile                      |  3 +-

You need to update MAINTAINERS for this new directory.

> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -217,6 +217,10 @@ endif # CONFIG_RTE_LIBRTE_DPAA_BUS
>  
>  endif # CONFIG_RTE_LIBRTE_CRYPTODEV
>  
> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF)$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL),yy)
> +_LDLIBS-y += -lrte_common_octeontx
> +endif
> +
>  ifeq ($(CONFIG_RTE_LIBRTE_EVENTDEV),y)
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_EVENTDEV) += -lrte_pmd_skeleton_event
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) += -lrte_pmd_sw_event

It is strange to insert common lib in the middle of PMDs after crypto
and before eventdev, in the "static-only" section.
I think it should be just after bus libs.

Please test static and shared library compilation.

Thanks