From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] ixgbe: fix segmentation fault when start secondary process Date: Fri, 19 Dec 2014 23:40:33 +0100 Message-ID: <1810907.O11zm5mpBE@xps13> References: <1418897809-14674-1-git-send-email-michael.qiu@intel.com> <1418972358-17130-1-git-send-email-michael.qiu@intel.com> <13515017.Dz1pkeJq4x@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Michael Qiu Return-path: In-Reply-To: <13515017.Dz1pkeJq4x@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-12-19 09:28, Thomas Monjalon: > 2014-12-19 14:59, Michael Qiu: > > EAL: probe driver: 8086:10fb rte_ixgbe_pmd > > EAL: PCI memory mapped at 0x7f18c2a00000 > > EAL: PCI memory mapped at 0x7f18c2a80000 > > Segmentation fault (core dumped) > > > > This is introduced by commit: 46bc9d75 > > ixgbe: fix multi-process support > > When start primary process with command line: > > ./app/test/test -n 1 -c ffff -m 64 > > then start the second one: > > ./app/test/test -n 1 --proc-type=secondary --file-prefix=rte > > This segment-fault will occur. > > > > Root cause is test app on primary process only starts device, but > > the queue need initialized by manually command line. > > So the tx queue is still NULL when secondary process startup. > > > > Reported-by: Yong Liu > > Signed-off-by: Michael Qiu > > --- > > v2 --> v1: > > Log clean up > > Clean-up failed: no need of \n in PMD_INIT_LOG ;) > > > + PMD_INIT_LOG(INFO, "No TX queues configured yet. " > > + "Using default TX function\n"); Applied with above change. Thanks -- Thomas