From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] Remove NO_AUTOLIBS option Date: Tue, 12 May 2015 15:07:14 +0200 Message-ID: <18120312.yv66er7Y4a@xps13> References: <1430490587-6806-1-git-send-email-keith.wiles@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Keith Wiles Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id EAF4D569E for ; Tue, 12 May 2015 15:07:56 +0200 (CEST) Received: by widdi4 with SMTP id di4so14691874wid.0 for ; Tue, 12 May 2015 06:07:56 -0700 (PDT) In-Reply-To: <1430490587-6806-1-git-send-email-keith.wiles@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-05-01 09:29, Keith Wiles: > NO_AUTOLIBS is not required as it was not used or defined in the config files. > > Signed-off-by: Keith Wiles > --- > mk/rte.app.mk | 5 ----- > 1 file changed, 5 deletions(-) Thanks Keith for trying to clean it, but removing half of an obsolete feature is not a real clean-up ;) When running "git grep NO_AUTOLIBS", it will return results in doc/guides/prog_guide I fixed the doc and manually applied your patch based on your _LDLIBS-y patch. Maybe I'm too kind, I know people who whould refuse this patch :) Sorry for being long here, but I want to show the work done when applying patches and I want to ask: is it a good thing to manually fix patches in order to speed-up the process or should it be more strict?