From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] net/tap: fix build issue with ARM32
Date: Wed, 31 Jan 2018 12:19:06 +0100
Message-ID: <1814250.kpiQluYUny@xps>
References: <20180131051408.3652-1-jerin.jacob@caviumnetworks.com>
 <20180131102352.GA24477@jerin>
 <AM0PR0502MB3875A2B143A6D122471D431BD1FB0@AM0PR0502MB3875.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Pascal Mazon <pascal.mazon@6wind.com>, Jan Viktorin <viktorin@rehivetech.com>,
 Jianbo Liu <jianbo.liu@arm.com>
To: Ophir Munk <ophirmu@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 763FB1B759
 for <dev@dpdk.org>; Wed, 31 Jan 2018 12:19:53 +0100 (CET)
In-Reply-To: <AM0PR0502MB3875A2B143A6D122471D431BD1FB0@AM0PR0502MB3875.eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

31/01/2018 11:38, Ophir Munk:
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > > arm architecture is missing is file drivers/tap/tap_bpf.h I suggest
> > > adding it, for example
> > >
> > > # elif defined(__arm__)
> > > #  define __NR_bpf 386
[...]
> > I am not sure, Is eBPF support available for arm32 support?
> 
> TAP eBPF has a graceful approach: it must successfully compile on all Linux
> distributions. If a specific kernel cannot support eBPF it will gracefully
> refuse the eBPF netlink message sent to it. 
> Thus, there is no harm even if there is no eBPF support available for arm32.
> 
> You should enable TAP compilation for cases where you only need TAP without eBPF.

Ophir, please send a patch.