From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 5/6] eal: remove xen dom0 support Date: Tue, 05 Sep 2017 09:31:28 +0200 Message-ID: <18154944.ikgZCrDS5M@xps> References: <1504116634-115687-1-git-send-email-jianfeng.tan@intel.com> <20170904144916.GE11856@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Richardson, Bruce" , dev@dpdk.org, xen-devel@lists.xenproject.org, "Mcnamara, John" , joao.m.martins@oracle.com, jerin.jacob@caviumnetworks.com, shahafs@mellanox.com To: "Tan, Jianfeng" Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id AEB9D3254 for ; Tue, 5 Sep 2017 09:31:30 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/09/2017 05:41, Tan, Jianfeng: > From: Richardson, Bruce > > > > Reading the contributors guide section on ABI, specifically > > http://dpdk.org/doc/guides/contributing/versioning.html#deprecating-an- > > entire-abi-version > > it seems like we should collapse down the versions to a single one > > following the function removal, and also increment the whole library so > > version. > > So for lib/librte_eal/linuxapp/eal/rte_eal_version.map, we should change it in below way? > > DPDK_2.1 { > {APIs in DPDK_2.0 except xen APIs} > ... > }; > > DPDK_16.04 { > {APIs in DPDK_2.1 except xen APIs} > ... > } DPDK_2.1; No, you don't need to collapse. You can just remove Xen functions.