From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [RFC PATCH] ethdev: remove old flow director API Date: Mon, 27 Apr 2015 18:08:55 +0200 Message-ID: <1815538.YzHUjUMMD8@xps13> References: <1429539103-15885-1-git-send-email-thomas.monjalon@6wind.com> <20150420163348.GA19573@hmsreliant.think-freely.org> <55352D47.8010906@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Venky Venkatesan , Neil Horman Return-path: In-Reply-To: <55352D47.8010906-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-04-20 09:45, Venky Venkatesan: > On 04/20/2015 09:33 AM, Neil Horman wrote: > > On Mon, Apr 20, 2015 at 04:11:43PM +0200, Thomas Monjalon wrote: > >> It's time to remove this old API. > >> It seems some work is still needed to rely only on eth_ctrl API. > >> At least ixgbe, i40e and testpmd must be fixed. > >> Jingjing, do you think it's possible to remove all these structures > >> from rte_ethdev.h? > >> > >> Thanks > >> > > NAK. > > > > I'm certainly not opposed to removing the API's if they are truly no longer > > needed. But they have been codified as part of the ABI, so the deprecation > > schedule needs to be followed. Given what you've said above, it seems like that > > might be worthwhile anyway, as it will provide the needed runway to allow users > > to convert to the new API. > > > > Neil > +1 NAK. Agree with Neil. +1 Agree with you :) The goal of this RFC proposal is to see how to progress on API cleanup. There are actually 2 parts: 1/ The flow director functions of rte_ethdev.h were only used for enic in DPDK 2.0. We could set a deprecation notice to remove them in DPDK 2.2. 2/ Some associated structures are also used for rte_eth_conf. My question was to check how it would be relevant to remove this rte_fdir_conf.