From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v9 2/3] Move common functions in eal_timer.c
Date: Mon, 27 Jul 2015 01:32:18 +0200
Message-ID: <18210927.c72O7E0spP@xps13>
References: <1437852868-6031-1-git-send-email-rkerur@gmail.com>
 <1437852990-6096-1-git-send-email-rkerur@gmail.com>
 <1437852990-6096-2-git-send-email-rkerur@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Ravi Kerur <rkerur@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id E59A5C45C
 for <dev@dpdk.org>; Mon, 27 Jul 2015 01:33:34 +0200 (CEST)
Received: by wibud3 with SMTP id ud3so93583343wib.0
 for <dev@dpdk.org>; Sun, 26 Jul 2015 16:33:34 -0700 (PDT)
In-Reply-To: <1437852990-6096-2-git-send-email-rkerur@gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-25 12:36, Ravi Kerur:
> +static void
> +set_tsc_freq_fallback(void)
> +{
> +	RTE_LOG(WARNING, EAL, "WARNING: clock_gettime cannot use "
> +		"CLOCK_MONOTONIC_RAW and HPET is not available"

Not generic enough for BSD.
We can say "TSC frequency estimated roughly"

> +		" - clock timings may be less accurate.\n");
> +	/* assume that the sleep(1) will sleep for 1 second */
[...]
> +/**
> + * This function sets TSC frequency from sysctl

It is not the style of the file to start with "This function..."

> + * for BSD and from clock for Linux.
> + * Is a wrapper function for BSD which will
> + * internally call set_tsc_freq_from_sysctl.

This sentence is an implementation detail.