From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v1] net/tap: return empty port offload
	capabilities
Date: Wed, 25 Apr 2018 18:47:51 +0200
Message-ID: <1822119.1fBLbGrzlv@xps>
References: <1524672957-4018-1-git-send-email-ophirmu@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Pascal Mazon <pascal.mazon@6wind.com>,
 Olga Shern <olgas@mellanox.com>, stable@dpdk.org
To: Ophir Munk <ophirmu@mellanox.com>, Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1524672957-4018-1-git-send-email-ophirmu@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

25/04/2018 18:15, Ophir Munk:
> Fix report on port offload capabilities to be 0 (no capabilities).
> Before this commit port capabilities were a clone of queue
> capabilities, however the current TAP offload capabilities (e.g.
> checksum calculation) are per queue and are not specific per port.

I did not follow what is the problem exactly.
But this change looks wrong to me.
Please look at the thread
	"Survey for final decision about per-port offload API"
	http://dpdk.org/ml/archives/dev/2018-March/094459.html
It says:
	"every queue capabilities must be reported as port capabilities"