From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] vfio: fix missing header inclusion
Date: Wed, 17 Oct 2018 10:18:09 +0200
Message-ID: <1822592.kQGmlEvfPa@xps>
References: <20181017052950.29078-1-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
 "jia.guo@intel.com" <jia.guo@intel.com>, "Jacob,
 Jerin" <Jerin.JacobKollanukkaran@cavium.com>, "Bhagavatula,
 Pavan" <Pavan.Bhagavatula@cavium.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id ED4DD7D34
 for <dev@dpdk.org>; Wed, 17 Oct 2018 10:18:08 +0200 (CEST)
In-Reply-To: <20181017052950.29078-1-jerin.jacob@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

17/10/2018 07:30, Jerin Jacob:
> The following change set introduces HAVE_VFIO_DEV_REQ_INTERFACE
> and used in the below files.
> 
> drivers/bus/pci/linux/pci_vfio.c
> drivers/bus/pci/pci_common.c
> lib/librte_eal/linuxapp/eal/eal_interrupts.c
> 
> However, Except the first file, the change missed to include
> <rte_vfio.h> where HAVE_VFIO_DEV_REQ_INTERFACE defined.
> This creates runtime following error on vfio-pci mode and
> kernel >= 4.0.0 combination.
> 
> EAL: [rte_intr_enable] Unknown handle type of fd 95
> EAL: [pci_vfio_enable_notifier]Fail to enable req notifier.
> EAL: Fail to unregister req notifier handler.
> EAL: Error setting up notifier!
> EAL: Requested device 0000:07:00.1 cannot be used
> 
> Fixes: cda94419964f ("vfio: fix build with Linux < 4.0")
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

Applied, thanks