From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85BCCC4320A for ; Wed, 4 Aug 2021 09:38:43 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id CB06D60EFD for ; Wed, 4 Aug 2021 09:38:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB06D60EFD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9B794014F; Wed, 4 Aug 2021 11:38:41 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 9D73D4003E for ; Wed, 4 Aug 2021 11:38:40 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 458065C0143; Wed, 4 Aug 2021 05:38:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 04 Aug 2021 05:38:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= o5BmdlZD/1corRxRVEVfBT0j5IGxFMWiXYX2FQQJup4=; b=tTCx9iBzz9+slC78 bC4qqWWgqgS/b4ip6Eo3TV1p8e+jBGZ1y7Nz2h2QDiWkZSLz9PmFcgwqgYTE4NbL xwMIWqcF6SHvqbhRTZIxgDPbTbt1e3qWib0NJXzUviMwFK3IrUlVBnNlHdXqy/Wl TTSlBV/NMyn86bv6SEJlULPl1w35zhpczF6TDbiOTNk9tecDOJYbB+9gL7ZGg5VA oaMg1YBzCzM8Mj0bZAWNCvKW+Gd4/wNYIjGKlk1gYAnRJe6VMEnH/YM1pcyBh/u+ rb0RmbpURyUfm+spQUE+tY1svxRf5iKNmj2KDMiQE5jKvnt7joDHWFfUgfAyFMd3 EfT44g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=o5BmdlZD/1corRxRVEVfBT0j5IGxFMWiXYX2FQQJu p4=; b=rXHCNddhXVR855lvWx56QPdC8V2eL7wsKz/5SEMi4UfsYt83t/M/WtVpO h9/tssiVbIRtM69C7GOeaKazHnTR1FJiqvvxDBlMO8cvLfVU0cCUOG2DSiXtRf5R 2dS6J/Gv3LIRqp5xveLol8oUgnmBY/CUTi2+0BU8C0du2UjZEgCZ6JjnlpZwto30 ZgSeru0PRiTQp9n5JD916M7us8eOZ6g92Kv0abaaxKda5l5kiANNj6Ba1JJrb7/6 A5LlIYWtlSd0onAxVNluCohh2hN4WWRurrrnRHC1sKzJzuz2HmZGtMnyprcsdFi4 UZ8o+89CS7VvstfkbnJOTekwXTy7w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrieejucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofho nhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrth htvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeuieeivdff geehnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepth hhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 4 Aug 2021 05:38:38 -0400 (EDT) From: Thomas Monjalon To: Gregory Etelson Cc: dev@dpdk.org, yux.jiang@intel.com, Matan Azrad , Raslan Darawsheh , Slava Ovsiienko , Xiaoyun Li , Ori Kam , Olivier Matz , Ajit Khaparde Date: Wed, 04 Aug 2021 11:38:37 +0200 Message-ID: <1823383.vttildH05X@thomas> In-Reply-To: References: <20210802180011.7183-1-getelson@nvidia.com> <20210802181316.7676-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix IPv4 checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > UDP protocol reserves 0 checksum value for special purposes. > > Other protocols, like IPv4, TCP and SCTP must calculate checksum value > > in software or offload checksum calculation to hardware. > > > > If IPv4 TX checksum offload was off and header checksum was set to 0, > > testpmd csum engine did not calculate checksum value for IPv4, TCP and > > SCTP. > > > > The patch always calculates IPv4, TCP and SCTP TX checksums if it is > > not offloaded. > > > > Fixes: b2a9e4a855d0 ("app/testpmd: fix Tx checksum calculation for tunnel") > > Bugzilla ID: 768 > > > > Signed-off-by: Gregory Etelson > Acked-by: Ajit Khaparde Applied, thanks.