From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 1/2] eal/bsd: fix FreeBSD build Date: Tue, 16 Oct 2018 13:38:57 +0100 Message-ID: <18236da2-c305-d03a-c877-9704e88b34d9@intel.com> References: <1539690060-133057-1-git-send-email-jia.guo@intel.com> <7ce45d10-71d3-5788-6124-3ee6a4c59288@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Jeff Guo , bruce.richardson@intel.com, thomas@monjalon.net Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 683B75F1D for ; Tue, 16 Oct 2018 14:39:01 +0200 (CEST) In-Reply-To: <7ce45d10-71d3-5788-6124-3ee6a4c59288@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/16/2018 1:04 PM, Ferruh Yigit wrote: > On 10/16/2018 12:41 PM, Jeff Guo wrote: >> When compiling on FreeBSD, a warning/error is thrown for >> unused parameter. This patch aim to fix the issue by delete >> the useless func definition. > > This function is part of the public API, so it should exist for FreeBSD, I think > instead of deleting the function we can add __rte_unused to parameters that are > not used to prevent build error. With second check, rte_dev_event_callback_process() seems already implemented in common, lib/librte_eal/common/eal_common_dev.c, and doesn't need linux/bsd specific implementation, so adding this to bsdapp seems error at first place. OK to remove function. Fixes: 89ecd110524d ("eal: modify device event process function") Reviewed-by: Ferruh Yigit > >> >> Signed-off-by: Jeff Guo >> --- >> lib/librte_eal/bsdapp/eal/eal_dev.c | 8 -------- >> 1 file changed, 8 deletions(-) >> >> diff --git a/lib/librte_eal/bsdapp/eal/eal_dev.c b/lib/librte_eal/bsdapp/eal/eal_dev.c >> index 3a3a2a5..255d611 100644 >> --- a/lib/librte_eal/bsdapp/eal/eal_dev.c >> +++ b/lib/librte_eal/bsdapp/eal/eal_dev.c >> @@ -33,11 +33,3 @@ rte_dev_hotplug_handle_disable(void) >> RTE_LOG(ERR, EAL, "Device event is not supported for FreeBSD\n"); >> return -1; >> } >> - >> -void __rte_experimental >> -rte_dev_event_callback_process(const char *device_name, >> - enum rte_dev_event_type event) >> -{ >> - RTE_LOG(ERR, EAL, >> - "Device event callback process is not supported for FreeBSD.\n"); >> -} >> >