From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 06/14] eal: arm: ret_vector.h improvements
Date: Wed, 18 Nov 2015 19:56:25 +0100
Message-ID: <1827952.FiSe5LrlIQ@xps13>
References: <1446802833-22265-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1446802833-22265-7-git-send-email-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 55E5611F5
 for <dev@dpdk.org>; Wed, 18 Nov 2015 19:57:40 +0100 (CET)
Received: by wmww144 with SMTP id w144so85593936wmw.0
 for <dev@dpdk.org>; Wed, 18 Nov 2015 10:57:40 -0800 (PST)
In-Reply-To: <1446802833-22265-7-git-send-email-jerin.jacob@caviumnetworks.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-11-06 15:10, Jerin Jacob:
> added the definition of rte_xmm and xmm_t for acl noen implementation.
> removed the emulated _mm_* functions

2 nits:
- noen -> neon
- this kind of change deserves more explanations

> +#include "arm_neon.h"

I think it should be <arm_neon.h>

It won't block the merge of this patch,
but as you are becoming the ARMv8 maintainer, please try to check
even minor things which make read of DPDK code and history easier.