From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] librte_ether: use RTE_ETH_VALID_PORTID_OR_ERR_RET to check port_id Date: Tue, 24 May 2016 15:31:58 +0200 Message-ID: <1829201.yogvSk4m0d@xps13> References: <1463515316-4949-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it> <1463598911-18176-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Mauricio Vasquez B Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id C35045677 for ; Tue, 24 May 2016 15:32:00 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id n129so130469739wmn.1 for ; Tue, 24 May 2016 06:32:00 -0700 (PDT) In-Reply-To: <1463598911-18176-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-05-18 21:15, Mauricio Vasquez B: > The RTE_ETH_VALID_PORTID_OR_ERR_RET macro is used in some places > to check if a port id is valid or not. This commit makes use of it in > some new parts of the code. > > Signed-off-by: Mauricio Vasquez B > --- > v3: > - use it also in rte_eth_add_rx_callback and rte_eth_add_tx_callback > v2: > - add missed case > - change also cases in examples/ethtool/lib/rte_ethtool.c > examples/ethtool/lib/rte_ethtool.c | 15 ++++++----- > lib/librte_ether/rte_ethdev.c | 51 +++++++++++++------------------------- > 2 files changed, 24 insertions(+), 42 deletions(-) I've fixed also 2 bond functions and removed some whitespace changes. Applied, thanks