From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4] doc/patches: add meson build to
	contributing guide
Date: Mon, 28 Jan 2019 01:39:12 +0100
Message-ID: <1830265.56Hsnbp04L@xps>
References: <20181030141847.23861-1-vipin.varghese@intel.com>
 <20190124230541.58343-1-vipin.varghese@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com,
 ferruh.yigit@intel.com, sanjay.padubidri@intel.com, amol.patel@intel.com
To: Vipin Varghese <vipin.varghese@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 75657316B
 for <dev@dpdk.org>; Mon, 28 Jan 2019 01:39:15 +0100 (CET)
In-Reply-To: <20190124230541.58343-1-vipin.varghese@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

25/01/2019 00:05, Vipin Varghese:
> Patches has to be validated for meson devtool script for
> code and document changes. Updating documentation for meson
> build steps in checking Compilation category.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> Tested-by: Marko Kovacevic <marko.kovacevic@intel.com>
> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
> ---
> 
> V4:
>  - spelling correction for Compilation - Thomas Monjalon
>  - restored double space for new header - Thomas Monjalon
>  - reword the meson compilation content - Vipin Varghese
>  - Added 'tested' and 'acked' from - Marko Kovacevic
> 
> V3:
>  removed extra character - Vipin Varghese
> 
> V2:
>  updated the meson build options - Bruce Richardson
> ---
>  doc/guides/contributing/patches.rst | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
> index a64bb0368..e9048bbc0 100644
> --- a/doc/guides/contributing/patches.rst
> +++ b/doc/guides/contributing/patches.rst
> @@ -473,6 +473,14 @@ The recommended configurations and options to test compilation prior to submitti
>     export DPDK_DEP_PCAP=y
>     export DPDK_DEP_SSL=y

The lines above are about the "make system".
We need a transition to explain that the "meson system" is different.

> +Compilation of patches is to be tested with ``test-meson-builds.sh`` script
> +in ``devtools`` directory of the DPDK repo::

Would be more straight-forward to give the full path:
	devtools/test-meson-builds.sh
No need to add "DPDK repo".

> +
> +   devtools/test-meson-builds.sh

Do we really need to repeat the script name here?

> +
> +The script internally checks for dependencies and tool chain. Then builds with

tool chain -> toolchain

> +shared and static libraries for Linux and BSD targets.

Why "Linux and BSD" ? It is just testing for the running OS.