From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 5/5] rte_sched: allow reading without clearing
Date: Fri, 10 Jul 2015 00:51:42 +0200
Message-ID: <1830896.dtZQMEj4sb@xps13>
References: <1432750217-4186-1-git-send-email-stephen@networkplumber.org>
 <1432750217-4186-6-git-send-email-stephen@networkplumber.org>
 <3EB4FA525960D640B5BDFFD6A3D89126323714E9@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com
 [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 772E05921
 for <dev@dpdk.org>; Fri, 10 Jul 2015 00:52:49 +0200 (CEST)
Received: by wiga1 with SMTP id a1so1094923wig.0
 for <dev@dpdk.org>; Thu, 09 Jul 2015 15:52:49 -0700 (PDT)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126323714E9@IRSMSX108.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-06-04 17:48, Dumitrescu, Cristian:
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > The rte_sched statistics API should allow reading statistics without
> > clearing. Make auto-clear optional. In this version, this is handled
> > by deprecating the old API and adding a new one.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
[...]
> > --- a/lib/librte_sched/rte_sched_version.map
> > +++ b/lib/librte_sched/rte_sched_version.map
> > @@ -14,8 +14,10 @@ DPDK_2.0 {
> >  	rte_sched_port_enqueue;
> >  	rte_sched_port_free;
> >  	rte_sched_port_get_memory_footprint;
> > +	rte_sched_queue_stats;
> >  	rte_sched_queue_read_stats;
> >  	rte_sched_subport_config;
> > +	rte_sched_subport_stats;
> >  	rte_sched_subport_read_stats;
> >  	rte_sched_port_pkt_write;
> >  	rte_sched_port_pkt_read_tree_path;
> 
> If we plan to obsolete API function rte_sched_queue_read_stats() and have people use the new API function rte_sched_queue_stats(), we should replace every usage of the obsolete function with call to new function. We need to do this in examples/qos_sched and app/test.

Patchwork status is now "Changes requested".