From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] qede: fix build with gcc >= 6.0
Date: Fri, 13 May 2016 17:37:54 +0200
Message-ID: <1831204.vI4CoI6YQS@xps13>
References: <bf736eb9491042b119d18c1401f7563b400e1e59.1462874485.git.pmatilai@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Panu Matilainen <pmatilai@redhat.com>, rasesh.mody@qlogic.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 68D9B9AA2
 for <dev@dpdk.org>; Fri, 13 May 2016 17:37:56 +0200 (CEST)
Received: by mail-wm0-f48.google.com with SMTP id g17so36552142wme.1
 for <dev@dpdk.org>; Fri, 13 May 2016 08:37:56 -0700 (PDT)
In-Reply-To: <bf736eb9491042b119d18c1401f7563b400e1e59.1462874485.git.pmatilai@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-05-10 13:01, Panu Matilainen:
> With gcc >= 6.0, qede base driver fails to build with:
> drivers/net/qede/base/ecore_cxt.c: In function 'ecore_cdu_init_common':
> cc1: error: left shift of negative value [-Werror=shift-negative-value]
> 
> Since the base drivers are untouchable, work around by disabling
> the warning.

Are the qede base driver files untouchable?

> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
[...]
> +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
> +CFLAGS_BASE_DRIVER += -Wno-shift-negative-value
> +endif

Fixes: ec94dbc57362 ("qede: add base driver")

Applied, thanks

Rasesh, would you mind to fix the base driver and remove this workaround?