From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v14 06/13] eal/linux: standalone intr event
	fd create support
Date: Mon, 20 Jul 2015 01:35:28 +0200
Message-ID: <1831628.YzNoj6xjSe@xps13>
References: <1434686442-578-1-git-send-email-cunming.liang@intel.com>
 <1437113775-32199-1-git-send-email-cunming.liang@intel.com>
 <1437113775-32199-7-git-send-email-cunming.liang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, shemming@brocade.com
To: Cunming Liang <cunming.liang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id C9C71C342
 for <dev@dpdk.org>; Mon, 20 Jul 2015 01:36:39 +0200 (CEST)
Received: by wgbcc4 with SMTP id cc4so25446555wgb.3
 for <dev@dpdk.org>; Sun, 19 Jul 2015 16:36:39 -0700 (PDT)
In-Reply-To: <1437113775-32199-7-git-send-email-cunming.liang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-17 14:16, Cunming Liang:
> +#ifdef RTE_NEXT_ABI
> +extern int
> +rte_intr_efd_enable(struct rte_intr_handle *intr_handle, uint32_t nb_efd);
> +#else
> +static inline int
> +rte_intr_efd_enable(struct rte_intr_handle *intr_handle, uint32_t nb_efd)
> +{
> +	RTE_SET_USED(intr_handle);
> +	RTE_SET_USED(nb_efd);
> +	return 0;
> +}
> +#endif
[...]
> +#ifdef RTE_NEXT_ABI
> +extern void
> +rte_intr_efd_disable(struct rte_intr_handle *intr_handle);
> +#else
> +static inline void
> +rte_intr_efd_disable(struct rte_intr_handle *intr_handle)
> +{
> +	RTE_SET_USED(intr_handle);
> +}
> +#endif
[...]
> +#ifdef RTE_NEXT_ABI
> +static inline int
> +rte_intr_dp_is_en(struct rte_intr_handle *intr_handle)
> +{
> +	return !(!intr_handle->nb_efd);
> +}
> +#else
> +static inline int
> +rte_intr_dp_is_en(struct rte_intr_handle *intr_handle)
> +{
> +	RTE_SET_USED(intr_handle);
> +	return 0;
> +}
> +#endif
[...]
> +#ifdef RTE_NEXT_ABI
> +static inline int
> +rte_intr_allow_others(struct rte_intr_handle *intr_handle)
> +{
> +	return !!(intr_handle->max_intr - intr_handle->nb_efd);
> +}
> +#else
> +static inline int
> +rte_intr_allow_others(struct rte_intr_handle *intr_handle)
> +{
> +	RTE_SET_USED(intr_handle);
> +	return 1;
> +}
> +#endif

Why these #else cases?

> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> @@ -117,6 +117,10 @@ DPDK_2.1 {
>  
>  	rte_epoll_ctl;
>  	rte_epoll_wait;
> +	rte_intr_allow_others;
> +	rte_intr_dp_is_en;
> +	rte_intr_efd_enable;
> +	rte_intr_efd_disable;

If RTE_NEXT_ABI is disabled, these symbols do not exist.
An alternate .map would be needed.