From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] examples/l3fwd: force CRC stripping for i40evf Date: Thu, 10 Nov 2016 08:55:34 +0100 Message-ID: <1831654.akRUm7xrPO@xps13> References: <20161109082341.19825-1-bjorn.topel@intel.com> <2DBBFF226F7CF64BAFCA79B681719D9537F2E51A@shsmsx102.ccr.corp.intel.com> <2fddae6f-d9ee-4dfb-2a4b-3ddcda830820@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: "Yao, Lei A" , "Zhang, Helin" , "Ananyev, Konstantin" , dev@dpdk.org, "Xu, Qian Q" , "Wu, Jingjing" To: =?ISO-8859-1?Q?Bj=F6rn_T=F6pel?= , "Topel, Bjorn" Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id C9AC037B8 for ; Thu, 10 Nov 2016 08:55:35 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id a197so351463027wmd.0 for ; Wed, 09 Nov 2016 23:55:35 -0800 (PST) In-Reply-To: <2fddae6f-d9ee-4dfb-2a4b-3ddcda830820@gmail.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-11-10 07:17, Bj=F6rn T=F6pel: > As discussed in the thread, it might be better to just change the > default in l3fwd from .hw_strip_crc =3D 0 to 1. >=20 > I'll be looking into changing igbvf and ixgbevf to match the semantic= s > of i40evf. Just to make it sure, you mean returning an error in the driver when a configuration cannot be applied, right?