From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] Make the thash library arch-independent
Date: Tue, 28 Jul 2015 15:47:57 +0200
Message-ID: <1831659.nSDl63dTav@xps13>
References: <1438088792-16344-1-git-send-email-medvedkinv@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Vladimir Medvedkin <medvedkinv@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 0EA3BC4F4
 for <dev@dpdk.org>; Tue, 28 Jul 2015 15:49:14 +0200 (CEST)
Received: by wicmv11 with SMTP id mv11so180445581wic.0
 for <dev@dpdk.org>; Tue, 28 Jul 2015 06:49:13 -0700 (PDT)
In-Reply-To: <1438088792-16344-1-git-send-email-medvedkinv@gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Vladimir,
Thanks for fixing.
Comments below.

2015-07-28 09:06, Vladimir Medvedkin:
> Signed-off-by: Vladimir Medvedkin <medvedkinv@gmail.com>

Please explain how it was broken and how you fixed it.
It would be interesting to know which part is __SSE3__ and __SSE__.

> +#ifdef __SSE3__
> +#include <rte_vect.h>
> +#endif /* __SSE3__ */

Comments after short ifdef block are not needed.

> +#ifndef XMM_SIZE
> +#define XMM_SIZE	16

Why is it needed?