From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v5 1/4] lib/librte_ether: support device reset
Date: Thu, 16 Jun 2016 17:36:44 +0200
Message-ID: <183283063.SXjPEFlxzi@xps13>
References: <1465191653-28408-1-git-send-email-wenzhuo.lu@intel.com>
 <1465959814-16557-1-git-send-email-wenzhuo.lu@intel.com>
 <1465959814-16557-2-git-send-email-wenzhuo.lu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com,
 jing.d.chen@intel.com, cunming.liang@intel.com, jingjing.wu@intel.com,
 helin.zhang@intel.com
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id D2148CBD0
 for <dev@dpdk.org>; Thu, 16 Jun 2016 17:36:47 +0200 (CEST)
Received: by mail-wm0-f42.google.com with SMTP id k184so32872453wme.1
 for <dev@dpdk.org>; Thu, 16 Jun 2016 08:36:47 -0700 (PDT)
In-Reply-To: <1465959814-16557-2-git-send-email-wenzhuo.lu@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-15 11:03, Wenzhuo Lu:
> +/**
> + * Reset an Ethernet device.
> + *
> + * @param port_id
> + *   The port identifier of the Ethernet device.
> + */
> +int
> +rte_eth_dev_reset(uint8_t port_id);

Please explain in the doxygen comment what means a reset.
We must understand why and when an application should call it.
And it must be clear for a PMD developper how to implement it.
What is the return value?