From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v14] ethdev: new Rx/Tx offloads API
Date: Mon, 14 May 2018 16:11:40 +0200
Message-ID: <1833263.kcaJZ8Err9@xps>
References: <1526299235-54090-1-git-send-email-wei.dai@intel.com>
 <1526304030-15507-1-git-send-email-wei.dai@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, ferruh.yigit@intel.com, Qi Zhang <qi.z.zhang@intel.com>
To: Wei Dai <wei.dai@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id AE0E01C893
 for <dev@dpdk.org>; Mon, 14 May 2018 16:11:43 +0200 (CEST)
In-Reply-To: <1526304030-15507-1-git-send-email-wei.dai@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

14/05/2018 15:20, Wei Dai:
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

[...]
>   *   hasn't been set in the input argument eth_conf->rxmode.offloads
>   *   to rte_eth_dev_configure(), it is a new added offloading, it must be
>   *   per-queue type and it is enabled for the queue.
> + *   No need to repeat any bit in rx_conf->offloads which has already been
> + *   enabled in rte_eth_dev_configure() at port level. An offloading enabled
> + *   at port level can't be disabled at queue level.

OK

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Thanks a lot Wei!